Quoting Chianna Rose.:" How many years do you guys think that we should wait? Should I wait until she's COMPLETELY done school? I really didnt want them to be too far apart though. Does 10 sound good? Or is that too far?"
This is something that you don't have to decide now, you can periodically re-evaluate... see where you guys stand a year from now, two years...
My sister and I are 9 years, 9 months, and 9 days apart and it defnitely had its up and down sides but we are really close now. There is no right or wrong way to space your family, only what is right for you. It sounds like you are really getting into a good place now, so it really seems like it is for the best that you keep building stability and financial security for now.